bug: stop fetching support bundle uri on airgap #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function `ParseSupportBundleFromDoc()` always attempt to fetch the support bundle from its uri (if present). there is another function that allows us to define if we want or not use the uri: ``` ParseSupportBundle() ``` this new function requires a second argument called `followURI` and we need to set it to false when kots is running in an airgap environment.
emosbaugh
reviewed
Oct 14, 2024
sgalsaleh
previously approved these changes
Oct 14, 2024
sgalsaleh
reviewed
Oct 14, 2024
addressing pr comments.
sgalsaleh
approved these changes
Oct 15, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-113580/ignore-preflight-uri-on-airgap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
the function
ParseSupportBundleFromDoc()always attempt to fetch the support bundle from its uri property (if present). there is another function that allows us to define if we want or not use the uri property:this new function requires a second argument called
followURIand we need to set it to false when kots is running in an airgap environment.